Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: allow l,n,p to be combined #788

Merged
merged 1 commit into from
Nov 7, 2024
Merged

ed: allow l,n,p to be combined #788

merged 1 commit into from
Nov 7, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 7, 2024

  • Other versions of ed allow numbered output with binary escapes
  • "p" is simply print
  • "pl"/"lp" == "l" and "pn"/"np" == "n"
  • "nl"/"ln" == number the lines and print the line in escaped mode
  • To make this work edPrint() needs to selectively allow an argument (technically a "command suffix")
  • test: g/rem/ln ---> edPrint() is called with $mode==$PRINT_BIN and $do_num is set based on $args[0]

@mknos
ed: allow l,n,p to be combined
71cc300 
* Other versions of ed allow numbered output with binary escapes
* "p" is simply print
* "pl"/"lp" == "l" and "pn"/"np" == "n"
* "nl"/"ln" == number the lines and print the line in escaped mode
* To make this work edPrint() needs to selectively allow an argument (technically a "command suffix")
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 7, 2024
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 7, 2024 15:27 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11726067498

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11721761222: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 25bba0e into briandfoy:master Nov 7, 2024
23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 7, 2024
@briandfoy briandfoy self-assigned this Nov 7, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy